[SYCL] Remove OoO Emulation #17943
Merged
[SYCL] Remove OoO Emulation #17943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e queues. Signed-off-by: James Brodman <[email protected]>
|
Note that I was seeing an issue in a Graph unit test. Graph recording was doing strange things. I added # if 1 / #endif around the test to easily toggle things on/off for now. If the actual commands during recording are omitted, it was fine. |
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
fabiomestre
approved these changes
Apr 10, 2025
Signed-off-by: James Brodman <[email protected]>
jbrodman
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: James Brodman <[email protected]>
jbrodman
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
The test fails were random test timeouts that seem unrelated to these changes. |
Turns out I also nuked 1 if statement too many. That resolves the Graph issue I was seeing. |
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
sergey-semenov
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the legacy implementation of emulation for OoO queues. This code predated the PI and UR layers in DPC++ because fpga OpenCL did not support OoO queues. Today, this type of thing should be done by the backend compiler or UR layer.